From aa977f5d96745d5ce61eb2da4b121a3299004ca8 Mon Sep 17 00:00:00 2001 From: Yuehong Wu Date: Thu, 29 Oct 2026 17:10:47 +0800 Subject: [PATCH] block: fix kernel-doc warnings in blk-map.c and blk-mq-dma.c make W=1 reports excess kernel-doc parameters for bio_copy_kern() and blk_rq_integrity_dma_map_iter_next(): block/blk-map.c:366: warning: Excess function parameter 'op' description in 'bio_copy_kern' block/blk-mq-dma.c:379: warning: Excess function parameter 'state' description in 'blk_rq_integrity_dma_map_iter_next' bio_copy_kern() derives the operation from @rq and has no @op argument, and blk_rq_integrity_dma_map_iter_next() lost its @state argument in commit 91e1c1bcf0f2 ("block, nvme: remove unused dma_iova_state function parameter"). Drop the stale parameter descriptions. While at it, fix the "ft" typo in the return value description of blk_rq_dma_map_iter_start() and blk_rq_dma_map_iter_next(). Signed-off-by: Yuehong Wu Link: https://patch.msgid.link/20261029091047.3085558-1-wuyuehong@cmss.chinamobile.com Signed-off-by: Jens Axboe --- block/blk-map.c | 1 - block/blk-mq-dma.c | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/block/blk-map.c b/block/blk-map.c index 0022710664bc..7369aba74771 100644 --- a/block/blk-map.c +++ b/block/blk-map.c @@ -357,7 +357,6 @@ static void bio_copy_kern_endio_read(struct bio *bio) * @rq: request to fill * @data: pointer to buffer to copy * @len: length in bytes - * @op: bio/request operation * @gfp_mask: allocation flags for bio and page allocation * * copy the kernel address into a bio suitable for io to a block diff --git a/block/blk-mq-dma.c b/block/blk-mq-dma.c index e0e7a18790b5..b89f4e6a17c3 100644 --- a/block/blk-mq-dma.c +++ b/block/blk-mq-dma.c @@ -215,7 +215,7 @@ static bool blk_dma_map_iter_start(struct request *req, struct device *dma_dev, * at unmap time, @iter is only needed at map time. * * Returns %false if there is no segment to map, including due to an error, or - * %true ft it did map a segment. + * %true if it did map a segment. * * If a segment was mapped, the DMA address for it is returned in @iter.addr and * the length in @iter.len. If no segment was mapped the status code is @@ -245,7 +245,7 @@ EXPORT_SYMBOL_GPL(blk_rq_dma_map_iter_start); * arguments. * * Returns %false if there is no segment to map, including due to an error, or - * %true ft it did map a segment. + * %true if it did map a segment. * * If a segment was mapped, the DMA address for it is returned in @iter.addr and * the length in @iter.len. If no segment was mapped the status code is @@ -363,7 +363,6 @@ EXPORT_SYMBOL_GPL(blk_rq_integrity_dma_map_iter_start); * a request * @req: request to map * @dma_dev: device to map to - * @state: DMA IOVA state * @iter: block layer DMA iterator * * Iterate to the next integrity mapping after a previous call to