github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

hwrng: amd - simplify control flow in amd_rng_mod_init()

Browse Source 
Replace the goto found statement with a break and check pdev after the
loop. Also consolidate the cleanup paths.

Signed-off-by: Thorsten Blum <blum@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Thorsten Blum 2026-10-02 16:19:51 +02:00 committed by Herbert Xu
parent 70f49f55a1
commit aa2c03d372
1 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/char/hw_random/amd-rng.c
View File

@ -129,19 +129,15 @@ static int __init amd_rng_mod_init(void)
{
int err;
struct pci_dev *pdev = NULL;
const struct pci_device_id *ent;
u32 pmbase;
struct amd768_priv *priv;
for_each_pci_dev(pdev) {
ent = pci_match_id(pci_tbl, pdev);
if (ent)
goto found;
}
/* Device not found. */
return -ENODEV;
for_each_pci_dev(pdev)
if (pci_match_id(pci_tbl, pdev))
break;
if (!pdev)
return -ENODEV;
found:
err = pci_read_config_dword(pdev, 0x58, &pmbase);
if (err) {
err = pcibios_err_to_errno(err);
@ -171,7 +167,7 @@ static int __init amd_rng_mod_init(void)
if (!priv->iobase) {
pr_err(DRV_NAME "Cannot map ioport\n");
err = -EINVAL;
goto err_iomap;
goto err;
}
amd_rng.priv = (unsigned long)priv;
@ -182,13 +178,12 @@ static int __init amd_rng_mod_init(void)
err = hwrng_register(&amd_rng);
if (err) {
pr_err(DRV_NAME " registering failed (%d)\n", err);
goto err_hwrng;
ioport_unmap(priv->iobase);
goto err;
}
return 0;
err_hwrng:
ioport_unmap(priv->iobase);
err_iomap:
err:
release_region(pmbase + PMBASE_OFFSET, PMBASE_SIZE);
out:
kfree(priv);