From a872e90e3668f9f8d0bc9c2fae3c328835b98bf0 Mon Sep 17 00:00:00 2001 From: Michael Tretter Date: Thu, 19 Feb 2026 12:32:57 +0100 Subject: [PATCH] drm/imx: ipuv3-plane: decouple zpos from plane type The overlay plane may be placed over or under the primary plane. Using zpos to determine, if the plane is the primary or overlay plane is not valid anymore. Use the plane type for determining the name of the plane in the error message. Reviewed-by: Philipp Zabel Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel Link: https://patch.msgid.link/20260219-drm-imx-underlay-plane-v2-1-26ef829c5483@pengutronix.de --- drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c index 0ea70b8fd743..ff483089b26b 100644 --- a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c @@ -915,7 +915,7 @@ struct ipu_plane *ipu_plane_init(struct drm_device *dev, struct ipu_soc *ipu, type, NULL); if (IS_ERR(ipu_plane)) { DRM_ERROR("failed to allocate and initialize %s plane\n", - zpos ? "overlay" : "primary"); + (type == DRM_PLANE_TYPE_PRIMARY) ? "primary" : "overlay"); return ipu_plane; } @@ -949,7 +949,7 @@ struct ipu_plane *ipu_plane_init(struct drm_device *dev, struct ipu_soc *ipu, ret = ipu_plane_get_resources(dev, ipu_plane); if (ret) { DRM_ERROR("failed to get %s plane resources: %pe\n", - zpos ? "overlay" : "primary", &ret); + (type == DRM_PLANE_TYPE_PRIMARY) ? "primary" : "overlay", &ret); return ERR_PTR(ret); }