rust: phy: use to_result for error handling

Simplifies error handling by replacing the manual check
of the return value with the `to_result` helper.

Signed-off-by: Onur Özkan <work@onurozkan.dev>
Reviewed-by: Elle Rhumsaa <elle@weathered-steel.dev>
Reviewed-by: Trevor Gross <tmgross@umich.edu>
Link: https://patch.msgid.link/20250821091235.800-1-work@onurozkan.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Onur Özkan 2025-08-21 12:12:35 +03:00 committed by Jakub Kicinski
parent 69cd993507
commit a7ddedc84c

View File

@ -196,11 +196,8 @@ pub fn read_paged(&mut self, page: u16, regnum: u16) -> Result<u16> {
// SAFETY: `phydev` is pointing to a valid object by the type invariant of `Self`.
// So it's just an FFI call.
let ret = unsafe { bindings::phy_read_paged(phydev, page.into(), regnum.into()) };
if ret < 0 {
Err(Error::from_errno(ret))
} else {
Ok(ret as u16)
}
to_result(ret).map(|()| ret as u16)
}
/// Resolves the advertisements into PHY settings.