github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-06 13:37:36 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

media: s5p-mfc: Add checking to s5p_mfc_probe().

Browse Source 
[ Upstream commit cdfaf4752e ]

If of_device_get_match_data() return NULL,
then null pointer dereference occurs in  s5p_mfc_init_pm().
The patch adds checking if dev->variant is NULL.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Nadezda Lutovinova 2021-08-11 15:32:28 +02:00 committed by Greg Kroah-Hartman
parent b570e36a77
commit a62edd8390
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/platform/s5p-mfc/s5p_mfc.c
View File

@ -1288,6 +1288,10 @@ static int s5p_mfc_probe(struct platform_device *pdev)
} }
dev->variant = of_device_get_match_data(&pdev->dev); dev->variant = of_device_get_match_data(&pdev->dev);
if (!dev->variant) {
dev_err(&pdev->dev, "Failed to get device MFC hardware variant information\n");
return -ENOENT;
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
dev->regs_base = devm_ioremap_resource(&pdev->dev, res); dev->regs_base = devm_ioremap_resource(&pdev->dev, res);