github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-31 19:47:08 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

btrfs: pass dentry to btrfs_mksubvol() and btrfs_mksnapshot()

Browse Source 
There's no reason to pass 'struct path' to btrfs_mksubvol(), though it's
been like the since the first commit 76dda93c6a ("Btrfs: add
snapshot/subvolume destroy ioctl").  We only use the dentry so we should
pass it directly.

Reviewed-by: Boris Burkov <boris@bur.io>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
David Sterba 2025-06-26 16:30:10 +02:00
parent 34f6cc5b18
commit a5f0e0a4df
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/btrfs/ioctl.c
View File

@ -892,13 +892,13 @@ static inline int btrfs_may_create(struct mnt_idmap *idmap,
* sys_mkdirat and vfs_mkdir, but we only do a single component lookup
* inside this filesystem so it's quite a bit simpler.
*/
static noinline int btrfs_mksubvol(const struct path *parent,
static noinline int btrfs_mksubvol(struct dentry *parent,
struct mnt_idmap *idmap,
struct qstr *qname, struct btrfs_root *snap_src,
bool readonly,
struct btrfs_qgroup_inherit *inherit)
{
struct inode *dir = d_inode(parent->dentry);
struct inode *dir = d_inode(parent);
struct btrfs_fs_info *fs_info = inode_to_fs_info(dir);
struct dentry *dentry;
struct fscrypt_str name_str = FSTR_INIT((char *)qname->name, qname->len);
@ -908,7 +908,7 @@ static noinline int btrfs_mksubvol(const struct path *parent,
if (ret == -EINTR)
return ret;
dentry = lookup_one(idmap, qname, parent->dentry);
dentry = lookup_one(idmap, qname, parent);
ret = PTR_ERR(dentry);
if (IS_ERR(dentry))
goto out_unlock;
@ -946,7 +946,7 @@ static noinline int btrfs_mksubvol(const struct path *parent,
return ret;
}
static noinline int btrfs_mksnapshot(const struct path *parent,
static noinline int btrfs_mksnapshot(struct dentry *parent,
struct mnt_idmap *idmap,
struct qstr *qname,
struct btrfs_root *root,
@ -1208,7 +1208,7 @@ static noinline int __btrfs_ioctl_snap_create(struct file *file,
}
if (subvol) {
ret = btrfs_mksubvol(&file->f_path, idmap, &qname, NULL,
ret = btrfs_mksubvol(file_dentry(file), idmap, &qname, NULL,
readonly, inherit);
} else {
CLASS(fd, src)(fd);
@ -1239,7 +1239,7 @@ static noinline int __btrfs_ioctl_snap_create(struct file *file,
*/
ret = -EINVAL;
} else {
ret = btrfs_mksnapshot(&file->f_path, idmap, &qname,
ret = btrfs_mksnapshot(file_dentry(file), idmap, &qname,
BTRFS_I(src_inode)->root,
readonly, inherit);
}