github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-27 00:22:00 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

xfs: remove NULL pointer checks in xfs_mru_cache_insert

Browse Source 
Remove the check for a NULL mru or mru->list in xfs_mru_cache_insert
as this API misused lead to a direct NULL pointer dereference on first
use and is not user triggerable.  As a smatch run by Dan points out
with the recent cleanup it would otherwise try to free the object we
just determined to be NULL for this impossible to reach case.

Fixes: 70b95cb865 ("xfs: free the item in xfs_mru_cache_insert on failure")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
This commit is contained in:
Christoph Hellwig 2025-06-05 08:16:28 +02:00 committed by Carlos Maiolino
parent b0f77d301e
commit a593c89ac5
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/xfs/xfs_mru_cache.c
View File

@ -425,10 +425,6 @@ xfs_mru_cache_insert(
{
int error = -EINVAL;
ASSERT(mru && mru->lists);
if (!mru || !mru->lists)
goto out_free;
error = -ENOMEM;
if (radix_tree_preload(GFP_KERNEL))
goto out_free;