github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-26 10:02:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

iio: light: opt3001: move device registration to end of probe()

Browse Source 
Move IIO device registration to the end of the probe() function to
follow standard driver teardown/setup ordering and improve driver
logic. Additionally, switch devm_iio_device_register() to its
unmanaged counterpart as current driver implementation mixes managed
and unmanaged resources, causing potential resource leaks.

Also, add iio_device_unregister() to remove() function to correctly
handle teardown.

Suggested-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
Joshua Crofts 2026-06-14 15:19:03 +02:00 committed by Jonathan Cameron
parent ec034d0981
commit a3ed4362d3
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/iio/light/opt3001.c
View File

@ -876,12 +876,6 @@ static int opt3001_probe(struct i2c_client *client)
iio->modes = INDIO_DIRECT_MODE;
iio->info = &opt3001_info;
ret = devm_iio_device_register(dev, iio);
if (ret) {
dev_err(dev, "failed to register IIO device\n");
return ret;
}
/* Make use of INT pin only if valid IRQ no. is given */
if (irq > 0) {
ret = request_threaded_irq(irq, NULL, opt3001_irq,
@ -896,7 +890,17 @@ static int opt3001_probe(struct i2c_client *client)
dev_dbg(opt->dev, "enabling interrupt-less operation\n");
}
ret = iio_device_register(iio);
if (ret)
goto free_irq;
return 0;
free_irq:
if (irq > 0)
free_irq(irq, iio);
return ret;
}
static void opt3001_remove(struct i2c_client *client)
@ -906,6 +910,8 @@ static void opt3001_remove(struct i2c_client *client)
int ret;
u16 reg;
iio_device_unregister(iio);
if (opt->use_irq)
free_irq(client->irq, iio);