From a0b64de6ea7e086f64ce97dec61e6639b334e13f Mon Sep 17 00:00:00 2001 From: bui duc phuc Date: Fri, 16 Oct 2026 11:09:45 +0700 Subject: [PATCH] ASoC: renesas: rz-ssi: Remove redundant component open callback In DMA mode, the generic dmaengine PCM component already applies the integer PERIODS constraint in snd_dmaengine_pcm_open(). Since rz_ssi_pcm_open_dma() only applies this constraint, remove the redundant component .open callback. Signed-off-by: bui duc phuc Link: https://patch.msgid.link/20261016040946.521195-11-phucduc.bui@gmail.com Signed-off-by: Mark Brown --- sound/soc/renesas/rz-ssi.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 9f36fe2c16d2..9a0781bb072d 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -954,19 +954,6 @@ static int rz_ssi_pcm_open_pio(struct snd_soc_component *component, return 0; } -static int rz_ssi_pcm_open_dma(struct snd_soc_component *component, - struct snd_pcm_substream *substream) -{ - int ret; - - ret = snd_pcm_hw_constraint_integer(substream->runtime, - SNDRV_PCM_HW_PARAM_PERIODS); - if (ret < 0) - return ret; - - return 0; -} - static snd_pcm_uframes_t rz_ssi_pcm_pointer(struct snd_soc_component *component, struct snd_pcm_substream *substream) { @@ -1017,7 +1004,6 @@ static const struct snd_soc_component_driver rz_ssi_soc_component_pio = { static const struct snd_soc_component_driver rz_ssi_soc_component_dma = { .name = "rz-ssi", - .open = rz_ssi_pcm_open_dma, .legacy_dai_naming = 1, };