github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

remoteproc: sysfs: Fix stale coredump attribute documentation

Browse Source 
The documentation of the 'coredump' sysfs entry still advertises a
"default" configuration option and describes it as the default value
of the entry.  Both date back to before the option was renamed to
"enabled" and the default configuration was changed to "disabled".

Update the comment to describe the three options the store callback
actually accepts, "disabled", "enabled" and "inline", along with the
real default value, and fix the coredump_show() comment which wrongly
claims the configuration is exposed via debugfs.

Assisted-by: Claude-Code:glm-5.3
Signed-off-by: Yonghao Zhang <hyz3367@gmail.com>
Link: https://lore.kernel.org/r/20260911030944.1645477-1-hyz3367@gmail.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
This commit is contained in:
Yonghao Zhang 2026-09-11 11:09:44 +08:00 committed by Mathieu Poirier
parent 749eed0c71
commit a020648a79
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/remoteproc/remoteproc_sysfs.c
View File

@ -76,7 +76,7 @@ static const char * const rproc_coredump_str[] = {
[RPROC_COREDUMP_INLINE] = "inline",
};
/* Expose the current coredump configuration via debugfs */
/* Expose the current coredump configuration via sysfs */
static ssize_t coredump_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
@ -87,14 +87,15 @@ static ssize_t coredump_show(struct device *dev,
/*
* By writing to the 'coredump' sysfs entry, we control the behavior of the
* coredump mechanism dynamically. The default value of this entry is "default".
* coredump mechanism dynamically. The default value of this entry is
* "disabled".
*
* The 'coredump' sysfs entry supports these commands:
*
* disabled: This is the default coredump mechanism. Recovery will proceed
* without collecting any dump.
*
* default: When the remoteproc crashes the entire coredump will be
* enabled: When the remoteproc crashes the entire coredump will be
* copied to a separate buffer and exposed to userspace.
*
* inline: The coredump will not be copied to a separate buffer and the