github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 09:36:22 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

wifi: mac80211: use kstrtobool_from_user() in debugfs callbacks

Browse Source 
Prefer 'kstrtobool_from_user()' over an ad-hoc quirks in
'aql_enable_write()' and 'force_tx_status_write()' callbacks.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Link: https://patch.msgid.link/20260417105556.2886928-1-dmantipov@yandex.ru
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Dmitry Antipov 2026-04-17 13:55:56 +03:00 committed by Johannes Berg
parent ab45ef0f6e
commit 9fd003edab
1 changed files with 13 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
net/mac80211/debugfs.c
View File

@ -320,26 +320,17 @@ static ssize_t aql_enable_read(struct file *file, char __user *user_buf,
static ssize_t aql_enable_write(struct file *file, const char __user *user_buf,
size_t count, loff_t *ppos)
{
char buf[3];
size_t len;
bool val;
int ret;
if (count > sizeof(buf))
return -EINVAL;
ret = kstrtobool_from_user(user_buf, count, &val);
if (unlikely(ret))
return ret;
if (copy_from_user(buf, user_buf, count))
return -EFAULT;
buf[sizeof(buf) - 1] = '\0';
len = strlen(buf);
if (len > 0 && buf[len - 1] == '\n')
buf[len - 1] = 0;
if (buf[0] == '0' && buf[1] == '\0')
static_branch_enable(&aql_disable);
else if (buf[0] == '1' && buf[1] == '\0')
if (val)
static_branch_disable(&aql_disable);
else
return -EINVAL;
static_branch_enable(&aql_disable);
return count;
}
@ -371,26 +362,14 @@ static ssize_t force_tx_status_write(struct file *file,
loff_t *ppos)
{
struct ieee80211_local *local = file->private_data;
char buf[3];
bool val;
int ret;
if (count >= sizeof(buf))
return -EINVAL;
if (copy_from_user(buf, user_buf, count))
return -EFAULT;
if (count && buf[count - 1] == '\n')
buf[count - 1] = '\0';
else
buf[count] = '\0';
if (buf[0] == '0' && buf[1] == '\0')
local->force_tx_status = 0;
else if (buf[0] == '1' && buf[1] == '\0')
local->force_tx_status = 1;
else
return -EINVAL;
ret = kstrtobool_from_user(user_buf, count, &val);
if (unlikely(ret))
return ret;
local->force_tx_status = val;
return count;
}