github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 22:14:04 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ANDROID: serdev: Fix platform device support

Browse Source 
After commit 3c996ff885 ("ANDROID: serdev: add platform device
support") landed, we started seeing boot panics on HiKey960/HiKey.

After some debugging I found the patch is passing a serdev_device->dev
pointer to match(), which expects the dev pointer to be
contained in a platform_device structure instead. When it uses
container_of, it ends up miscast and we get bad values.

Alistair suggested this fix which seems to avoid the issue.

Signed-off-by: John Stultz <john.stultz@linaro.org>
Bug: 146517987
Change-Id: I6354aeb4008fff85264a3c848c6c95fb8ca5b07a
This commit is contained in:
John Stultz 2020-01-02 21:13:09 +00:00 committed by Alistair Delva
parent 0a94995d7a
commit 9b460a068c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/tty/serdev/core.c
View File

@ -65,7 +65,7 @@ static int serdev_device_uevent(struct device *dev, struct kobj_uevent_env *env)
return rc;
if (dev->parent->parent->bus == &platform_bus_type)
rc = dev->parent->parent->bus->uevent(dev, env);
rc = dev->parent->parent->bus->uevent(dev->parent->parent, env);
return rc;
}
@ -110,7 +110,7 @@ static int serdev_device_match(struct device *dev, struct device_driver *drv)
return 1;
if (dev->parent->parent->bus == &platform_bus_type &&
dev->parent->parent->bus->match(dev, drv))
dev->parent->parent->bus->match(dev->parent->parent, drv))
return 1;
return 0;