github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 10:09:10 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

bpf: replace pop/push emptiness check with bpf_list_empty()

Browse Source 
Simplify fq_flows_is_empty() by replacing the pop/push based emptiness
check with a direct call to bpf_list_empty().
This avoids unnecessary list mutation and simplifies the code while
preserving correctness.

Signed-off-by: Suchit Karunakaran <suchitkarunakaran@gmail.com>

Changes since v1:
- Removed unused variable node
Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com>
Link: https://lore.kernel.org/r/20260524025853.13786-1-suchitkarunakaran@gmail.com

Signed-off-by: Alexei Starovoitov <ast@kernel.org>
This commit is contained in:
Suchit Karunakaran 2026-05-24 08:28:53 +05:30 committed by Alexei Starovoitov
parent 9b435d23f5
commit 9a720e090e
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c
View File

@ -196,18 +196,13 @@ fq_flows_remove_front(struct bpf_list_head *head, struct bpf_spin_lock *lock,
static bool
fq_flows_is_empty(struct bpf_list_head *head, struct bpf_spin_lock *lock)
{
struct bpf_list_node *node;
bool empty;
bpf_spin_lock(lock);
node = bpf_list_pop_front(head);
if (node) {
bpf_list_push_front(head, node);
bpf_spin_unlock(lock);
return false;
}
empty = bpf_list_empty(head);
bpf_spin_unlock(lock);
return true;
return empty;
}
/* flow->age is used to denote the state of the flow (not-detached, detached, throttled)