github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 14:04:54 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

scsi: libsas: Use _safe() loop in sas_resume_port()

Browse Source 
[ Upstream commit 8c7e7b8486 ]

If sas_notify_lldd_dev_found() fails then this code calls:

	sas_unregister_dev(port, dev);

which removes "dev", our list iterator, from the list.  This could lead to
an endless loop.  We need to use list_for_each_entry_safe().

Link: https://lore.kernel.org/r/YKUeq6gwfGcvvhty@mwanda
Fixes: 303694eeee ("[SCSI] libsas: suspend / resume support")
Reviewed-by: John Garry <john.garry@huawei.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter 2021-05-19 17:20:27 +03:00 committed by Greg Kroah-Hartman
parent 3a17d8adfa
commit 988439906f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/libsas/sas_port.c
View File

@ -25,7 +25,7 @@ static bool phy_is_wideport_member(struct asd_sas_port *port, struct asd_sas_phy
static void sas_resume_port(struct asd_sas_phy *phy) static void sas_resume_port(struct asd_sas_phy *phy)
{ {
struct domain_device *dev; struct domain_device *dev, *n;
struct asd_sas_port *port = phy->port; struct asd_sas_port *port = phy->port;
struct sas_ha_struct *sas_ha = phy->ha; struct sas_ha_struct *sas_ha = phy->ha;
struct sas_internal *si = to_sas_internal(sas_ha->core.shost->transportt); struct sas_internal *si = to_sas_internal(sas_ha->core.shost->transportt);
@ -44,7 +44,7 @@ static void sas_resume_port(struct asd_sas_phy *phy)
* 1/ presume every device came back * 1/ presume every device came back
* 2/ force the next revalidation to check all expander phys * 2/ force the next revalidation to check all expander phys
*/ */
list_for_each_entry(dev, &port->dev_list, dev_list_node) { list_for_each_entry_safe(dev, n, &port->dev_list, dev_list_node) {
int i, rc; int i, rc;
rc = sas_notify_lldd_dev_found(dev); rc = sas_notify_lldd_dev_found(dev);