github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-22 04:34:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/amdgpu: Fix IP block NULL check during soft reset

Browse Source 
We can't print the IP block name when the IP block is NULL.

Note that it should never be NULL, the only way that
can happen is when amdgpu_ip_from_ring() is missing the
given ring type. The check is just there to be sure.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202607031711.yLwFhGfp-lkp@intel.com/
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Timur Kristóf 2026-07-10 09:36:48 +02:00 committed by Alex Deucher
parent 9546c8a9ac
commit 982b2a4368
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/drm/amd/amdgpu/amdgpu_ip.c
View File

@ -489,7 +489,13 @@ int amdgpu_device_ip_soft_reset(struct amdgpu_ring *guilty_ring,
ip_type = amdgpu_ip_from_ring(guilty_ring->funcs->type);
ip_block = amdgpu_device_ip_get_ip_block(adev, ip_type);
if (!ip_block || !ip_block->version->funcs->soft_reset) {
if (unlikely(!ip_block)) {
dev_warn(adev->dev, "IP block not found for ring %s\n",
guilty_ring->name);
return -EOPNOTSUPP;
}
if (!ip_block->version->funcs->soft_reset) {
dev_warn(adev->dev, "IP block soft reset not supported on %s\n",
ip_block->version->funcs->name);
return -EOPNOTSUPP;