github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 18:21:24 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

staging: rtl8723bs: change custom comparing function to strcmp()

Browse Source 
eqNByte() function is a redundant reimplementation of strcmp().
Remove eqNByte() and switch its usages to strcmp().
No functional change.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bera Yüzlü <b9788213@gmail.com>
Link: https://patch.msgid.link/20260309184556.846-2-b9788213@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Bera Yüzlü 2026-03-09 21:45:56 +03:00 committed by Greg Kroah-Hartman
parent 77da49db33
commit 97eef87a54
3 changed files with 10 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/rtl8723bs/hal/hal_com.c
View File

@ -750,18 +750,6 @@ void SetHalODMVar(
}
bool eqNByte(u8 *str1, u8 *str2, u32 num)
{
if (num == 0)
return false;
while (num > 0) {
num--;
if (str1[num] != str2[num])
return false;
}
return true;
}
bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt)
{
u16 i = 0;

19
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
View File

@ -8,6 +8,7 @@
#include <drv_types.h>
#include <hal_data.h>
#include <linux/kernel.h>
#include <linux/string.h>
u8 PHY_GetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
enum rate_section RateSection)
@ -819,27 +820,27 @@ void PHY_SetTxPowerLimit(
powerLimit = powerLimit > MAX_POWER_INDEX ? MAX_POWER_INDEX : powerLimit;
if (eqNByte(Regulation, (u8 *)("FCC"), 3))
if (strcmp(Regulation, "FCC") == 0)
regulation = 0;
else if (eqNByte(Regulation, (u8 *)("MKK"), 3))
else if (strcmp(Regulation, "MKK") == 0)
regulation = 1;
else if (eqNByte(Regulation, (u8 *)("ETSI"), 4))
else if (strcmp(Regulation, "ETSI") == 0)
regulation = 2;
else if (eqNByte(Regulation, (u8 *)("WW13"), 4))
else if (strcmp(Regulation, "WW13") == 0)
regulation = 3;
if (eqNByte(RateSection, (u8 *)("CCK"), 3) && eqNByte(RfPath, (u8 *)("1T"), 2))
if (strcmp(RateSection, "CCK") == 0 && strcmp(RfPath, "1T") == 0)
rateSection = 0;
else if (eqNByte(RateSection, (u8 *)("OFDM"), 4) && eqNByte(RfPath, (u8 *)("1T"), 2))
else if (strcmp(RateSection, "OFDM") == 0 && strcmp(RfPath, "1T") == 0)
rateSection = 1;
else if (eqNByte(RateSection, (u8 *)("HT"), 2) && eqNByte(RfPath, (u8 *)("1T"), 2))
else if (strcmp(RateSection, "HT") == 0 && strcmp(RfPath, "1T") == 0)
rateSection = 2;
else
return;
if (eqNByte(Bandwidth, (u8 *)("20M"), 3))
if (strcmp(Bandwidth, "20M") == 0)
bandwidth = 0;
else if (eqNByte(Bandwidth, (u8 *)("40M"), 3))
else if (strcmp(Bandwidth, "40M") == 0)
bandwidth = 1;
channelIndex = phy_GetChannelIndexOfTxPowerLimit(channel);

2
drivers/staging/rtl8723bs/include/hal_com.h
View File

@ -141,8 +141,6 @@ void rtw_hal_check_rxfifo_full(struct adapter *adapter);
u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable,
void *value);
bool eqNByte(u8 *str1, u8 *str2, u32 num);
bool GetU1ByteIntegerFromStringInDecimal(char *str, u8 *in);
#define HWSET_MAX_SIZE 512