mirror of
https://github.com/torvalds/linux.git
synced 2026-07-27 17:47:41 +02:00
stddef: Document designated initializer semantics for __TRAILING_OVERLAP()
Document the designated initializer behavior for overlapping storage between NAME and MEMBERS, and clarify the implications for static initialization to help avoid unintended overwrites. Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://patch.msgid.link/agD0R-kNbg9YMOCT@kspp Signed-off-by: Kees Cook <kees@kernel.org>
This commit is contained in:
parent
7fd2df204f
commit
97d272699e
|
|
@ -100,6 +100,71 @@ enum {
|
|||
* Creates a union between a flexible-array member (FAM) in a struct and a set
|
||||
* of additional members that would otherwise follow it.
|
||||
*
|
||||
* Beware that, as this helper encloses TYPE NAME and MEMBERS in the same
|
||||
* union, designated initializers for MEMBERS may overwrite portions
|
||||
* previously initialized through NAME.
|
||||
*
|
||||
* For example::
|
||||
*
|
||||
* struct flex {
|
||||
* size_t count;
|
||||
* u8 fam[];
|
||||
* };
|
||||
*
|
||||
* struct composite {
|
||||
* ...
|
||||
* __TRAILING_OVERLAP(struct flex, flex, fam, __packed,
|
||||
* u8 data;
|
||||
* );
|
||||
* } __packed;
|
||||
*
|
||||
* static struct composite comp = {
|
||||
* .flex = {
|
||||
* .count = 1,
|
||||
* },
|
||||
* .data = 2,
|
||||
* };
|
||||
*
|
||||
* In the example above, .flex and .data initialize different views of the same
|
||||
* union storage. Since .data is initialized last, it _may_ overwrite portions
|
||||
* previously initialized through .flex, leading to .flex.count being zeroed
|
||||
* out.
|
||||
*
|
||||
* A couple of alternatives are shown below.
|
||||
*
|
||||
* a) Initialize only one view of the overlapped storage and assign the rest
|
||||
* at runtime::
|
||||
*
|
||||
* static struct composite comp = {
|
||||
* .flex = {
|
||||
* .count = 1,
|
||||
* },
|
||||
* };
|
||||
*
|
||||
* static void foo(void)
|
||||
* {
|
||||
* comp.data = 2;
|
||||
* ...
|
||||
* }
|
||||
*
|
||||
* b) Alternatively, replace designated initializers with runtime assignments::
|
||||
*
|
||||
* static void foo(void)
|
||||
* {
|
||||
* struct composite comp;
|
||||
*
|
||||
* comp.flex.count = 1;
|
||||
* comp.data = 2;
|
||||
* ...
|
||||
* }
|
||||
*
|
||||
* Compiler Explorer test code: https://godbolt.org/z/voM4E36dT
|
||||
*
|
||||
* For another example of the above see commit 5e54510a9389 ("acpi: nfit:
|
||||
* intel: avoid multiple -Wflex-array-member-not-at-end warnings")
|
||||
*
|
||||
* Link: https://git.kernel.org/linus/5e54510a9389caa9
|
||||
*
|
||||
* @TYPE: Flexible structure type name, including "struct" keyword.
|
||||
* @NAME: Name for a variable to define.
|
||||
* @FAM: The flexible-array member within @TYPE
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user