github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-13 15:40:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

selftests/mm: kmemleak: drop stale min_unref_scans default from comments

Browse Source 
The test writes min_unref_scans explicitly for every case, so its comments
describing 1 as the default are both unnecessary and, since the default is
now conditional, wrong.  Refer to the threshold values directly.

No functional change.

Link: https://lore.kernel.org/20260731-kmemleak_hardened-v2-3-7b9689ac77cb@debian.org
Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Hildenbrand <david@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Breno Leitao 2026-07-31 03:13:06 -07:00 committed by Andrew Morton
parent 09dde5e9ba
commit 972195eb9b
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/testing/selftests/mm/ksft_kmemleak_confirm.sh
View File

@ -5,7 +5,7 @@
# (the min_unref_scans module parameter).
#
# kmemleak only reports an object once it has stayed unreferenced for
# min_unref_scans consecutive scans. The default of 1 reports on the first
# min_unref_scans consecutive scans. A threshold of 1 reports on the first
# scan (historical behaviour); higher values filter transient false
# positives where a live object's only reference is briefly invisible to a
# single scan (e.g. an RCU tree update in flight while the scan runs). The
@ -16,8 +16,7 @@
# - a freshly allocated object is greyed on its first scan (its checksum
# settles then), so nothing can be reported before that priming scan;
# each case below primes once first,
# - with the default threshold (min_unref_scans=1) one scan after priming
# reports the orphans,
# - at min_unref_scans=1 one scan after priming reports the orphans,
# - raising the threshold to 2 needs two scans after priming: one is not
# enough, the second reports,
# - the parameter reads back what was written.
@ -105,9 +104,8 @@ echo 3 > "$PARAM"
# scan. Every case below runs this priming scan before counting.
prime() { scan; }
# 1) min_unref_scans=1 (default): one scan after priming reports the
# orphans. This also establishes that the helper produces detectable
# orphans here.
# 1) min_unref_scans=1: one scan after priming reports the orphans. This
# also establishes that the helper produces detectable orphans here.
echo 1 > "$PARAM"
gen_orphans
prime