sched/walt: Remove unused sched_dynamic_ravg_window_enable tunable

sched_dynamic_ravg_window_enable tunable is not currently used. If 0
is written to this tunable, the dynamic window size feature is disabled
in the kernel which results in bad performance. So remove this unused
tunable.

Change-Id: I64282146e526f98d049be25502ef638f538b0496
Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
This commit is contained in:
Pavankumar Kondeti 2021-04-09 09:41:37 +05:30 committed by Rishabh Bhatnagar
parent 60dadb8382
commit 960f8d4f0f
2 changed files with 1 additions and 14 deletions

View File

@ -47,7 +47,6 @@ unsigned int __read_mostly sysctl_sched_group_downmigrate_pct;
unsigned int __read_mostly sysctl_sched_group_upmigrate_pct;
unsigned int __read_mostly sysctl_sched_window_stats_policy;
unsigned int sysctl_sched_ravg_window_nr_ticks;
unsigned int sysctl_sched_dynamic_ravg_window_enable;
unsigned int sysctl_sched_walt_rotate_big_tasks;
unsigned int sysctl_sched_task_unfilter_period;
unsigned int __read_mostly sysctl_sched_asym_cap_sibling_freq_match_pct;
@ -182,7 +181,7 @@ static int sched_ravg_window_handler(struct ctl_table *table,
mutex_lock(&mutex);
if (write && (HZ != 250 || !sysctl_sched_dynamic_ravg_window_enable))
if (write && HZ != 250)
goto unlock;
ret = proc_dointvec(&tmp, write, buffer, lenp, ppos);
@ -675,15 +674,6 @@ struct ctl_table walt_table[] = {
.mode = 0644,
.proc_handler = sched_ravg_window_handler,
},
{
.procname = "sched_dynamic_ravg_window_enable",
.data = &sysctl_sched_dynamic_ravg_window_enable,
.maxlen = sizeof(unsigned int),
.mode = 0644,
.proc_handler = proc_dointvec_minmax,
.extra1 = SYSCTL_ZERO,
.extra2 = SYSCTL_ONE,
},
{
.procname = "sched_upmigrate",
.data = &sysctl_sched_capacity_margin_up_pct,
@ -830,8 +820,6 @@ void walt_tunables(void)
sysctl_sched_ravg_window_nr_ticks = (HZ / NR_WINDOWS_PER_SEC);
sysctl_sched_dynamic_ravg_window_enable = (HZ == 250);
sched_load_granule = DEFAULT_SCHED_RAVG_WINDOW / NUM_LOAD_INDICES;
for (i = 0; i < WALT_NR_CPUS; i++) {

View File

@ -271,7 +271,6 @@ extern unsigned int __read_mostly sysctl_sched_group_downmigrate_pct;
extern unsigned int __read_mostly sysctl_sched_group_upmigrate_pct;
extern unsigned int __read_mostly sysctl_sched_window_stats_policy;
extern unsigned int sysctl_sched_ravg_window_nr_ticks;
extern unsigned int sysctl_sched_dynamic_ravg_window_enable;
extern unsigned int sysctl_sched_walt_rotate_big_tasks;
extern unsigned int sysctl_sched_task_unfilter_period;
extern unsigned int __read_mostly sysctl_sched_asym_cap_sibling_freq_match_pct;