github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 17:47:41 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

intel_th: fix device leak on output open()

Browse Source 
Make sure to drop the reference taken when looking up the th device
during output device open() on errors and on close().

Note that a recent commit fixed the leak in a couple of open() error
paths but not all of them, and the reference is still leaking on
successful open().

Fixes: 39f4034693 ("intel_th: Add driver infrastructure for Intel(R) Trace Hub devices")
Fixes: 6d5925b667 ("intel_th: Fix error handling in intel_th_output_open")
Cc: stable@vger.kernel.org	# 4.4: 6d5925b667
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ma Ke <make24@iscas.ac.cn>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20251208153524.68637-2-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2025-12-08 16:35:23 +01:00 committed by Greg Kroah-Hartman
parent 10d28cffb3
commit 95fc36a234
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/hwtracing/intel_th/core.c
View File

@ -810,9 +810,12 @@ static int intel_th_output_open(struct inode *inode, struct file *file)
int err; int err;
dev = bus_find_device_by_devt(&intel_th_bus, inode->i_rdev); dev = bus_find_device_by_devt(&intel_th_bus, inode->i_rdev);
if (!dev || !dev->driver) { if (!dev)
return -ENODEV;
if (!dev->driver) {
err = -ENODEV; err = -ENODEV;
goto out_no_device; goto out_put_device;
} }
thdrv = to_intel_th_driver(dev->driver); thdrv = to_intel_th_driver(dev->driver);
@ -836,12 +839,22 @@ static int intel_th_output_open(struct inode *inode, struct file *file)
out_put_device: out_put_device:
put_device(dev); put_device(dev);
out_no_device:
return err; return err;
} }
static int intel_th_output_release(struct inode *inode, struct file *file)
{
struct intel_th_device *thdev = file->private_data;
put_device(&thdev->dev);
return 0;
}
static const struct file_operations intel_th_output_fops = { static const struct file_operations intel_th_output_fops = {
.open = intel_th_output_open, .open = intel_th_output_open,
.release = intel_th_output_release,
.llseek = noop_llseek, .llseek = noop_llseek,
}; };