From 95545ddcb3cfb390c59429b1c18aaf187d6768ba Mon Sep 17 00:00:00 2001 From: Miles Krause Date: Sun, 12 Jul 2026 21:07:11 -0400 Subject: [PATCH] auxdisplay: panel: Remove unused callback binding code panel_bind_callback() has been compiled out with #if 0 since the commit 630231776da4916e ("Staging: panel: remove support for smartcards") in v2.6.29 and now has no callers. Remove the dead function to reduce maintenance burden. No functional change. Signed-off-by: Miles Krause Reviewed-by: Geert Uytterhoeven Acked-by: Willy Tarreau Link: https://patch.msgid.link/20260712-panel-remove-dead-callback-v1-1-1091ce75b8d5@gmail.com [andy: update commit message as suggested by Geert] Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/panel.c | 37 ------------------------------------- 1 file changed, 37 deletions(-) diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c index d8854cf15268..a7dfc53157bc 100644 --- a/drivers/auxdisplay/panel.c +++ b/drivers/auxdisplay/panel.c @@ -1450,43 +1450,6 @@ static struct logical_input *panel_bind_key(const char *name, const char *press, return key; } -#if 0 -/* tries to bind a callback function to the signal name . The function - * will be called with the arg when the signal is - * activated, and so on for / - * Returns the pointer to the new signal if ok, NULL if the signal could not - * be bound. - */ -static struct logical_input *panel_bind_callback(char *name, - void (*press_fct)(int), - int press_data, - void (*release_fct)(int), - int release_data) -{ - struct logical_input *callback; - - callback = kmalloc(sizeof(*callback), GFP_KERNEL); - if (!callback) - return NULL; - - memset(callback, 0, sizeof(struct logical_input)); - if (!input_name2mask(name, &callback->mask, &callback->value, - &scan_mask_i, &scan_mask_o)) - return NULL; - - callback->type = INPUT_TYPE_STD; - callback->state = INPUT_ST_LOW; - callback->rise_time = 1; - callback->fall_time = 1; - callback->u.std.press_fct = press_fct; - callback->u.std.press_data = press_data; - callback->u.std.release_fct = release_fct; - callback->u.std.release_data = release_data; - list_add(&callback->list, &logical_inputs); - return callback; -} -#endif - static void keypad_init(void) { int keynum;