github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-12 16:18:45 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

w1: ds2490: drop redundant device reference

Browse Source 
Driver core holds a reference to the USB interface and its parent USB
device while the interface is bound to a driver and there is no need to
take additional references unless the structures are needed after
disconnect.

Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260305111613.18546-1-johan@kernel.org
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://patch.msgid.link/20260403084450.6314-2-krzk@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2026-04-03 10:44:51 +02:00 committed by Greg Kroah-Hartman
parent a1ed2cbb79
commit 94e731cbe8
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/w1/masters/ds2490.c
View File

@ -1022,11 +1022,8 @@ static int ds_probe(struct usb_interface *intf,
if (!dev) if (!dev)
return -ENOMEM; return -ENOMEM;
dev->udev = usb_get_dev(udev); dev->udev = udev;
if (!dev->udev) {
err = -ENOMEM;
goto err_out_free;
}
memset(dev->ep, 0, sizeof(dev->ep)); memset(dev->ep, 0, sizeof(dev->ep));
usb_set_intfdata(intf, dev); usb_set_intfdata(intf, dev);
@ -1085,9 +1082,8 @@ static int ds_probe(struct usb_interface *intf,
err_out_clear: err_out_clear:
usb_set_intfdata(intf, NULL); usb_set_intfdata(intf, NULL);
usb_put_dev(dev->udev);
err_out_free:
kfree(dev); kfree(dev);
return err; return err;
} }
@ -1107,7 +1103,6 @@ static void ds_disconnect(struct usb_interface *intf)
usb_set_intfdata(intf, NULL); usb_set_intfdata(intf, NULL);
usb_put_dev(dev->udev);
kfree(dev); kfree(dev);
} }