scsi: bnx2fc: Enable lock context analysis

Document the locking requirements with __must_hold(). Make the argument
names in the definition and the declaration of
bnx2fc_process_seq_cleanup_compl() consistent.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/224219367c2af9fc4d193d0568bb8a6e8d22f97d.1790360262.git.bvanassche@acm.org
Signed-off-by: Martin K. Petersen (Oracle) <mkp@kernel.org>
This commit is contained in:
Bart Van Assche 2026-09-25 11:25:56 -07:00 committed by Martin K. Petersen (Oracle)
parent 32f9cdb45b
commit 9495fadabe
4 changed files with 8 additions and 1 deletions

View File

@ -1,4 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
CONTEXT_ANALYSIS := y
obj-$(CONFIG_SCSI_BNX2X_FCOE) += bnx2fc.o
bnx2fc-y := bnx2fc_els.o bnx2fc_fcoe.o bnx2fc_hwi.o bnx2fc_io.o bnx2fc_tgt.o \

View File

@ -596,7 +596,8 @@ int bnx2fc_send_srr(struct bnx2fc_cmd *orig_io_req, u32 offset, u8 r_ctl);
void bnx2fc_process_seq_cleanup_compl(struct bnx2fc_rport *tgt,
struct bnx2fc_cmd *seq_clnp_req,
struct fcoe_task_ctx_entry *task,
u8 rx_state);
u8 rx_state)
__must_hold(&tgt->tgt_lock);
int bnx2fc_initiate_seq_cleanup(struct bnx2fc_cmd *orig_io_req, u32 offset,
enum fc_rctl r_ctl);

View File

@ -265,6 +265,7 @@ int bnx2fc_send_rls(struct bnx2fc_rport *tgt, struct fc_frame *fp)
static void bnx2fc_srr_compl(struct bnx2fc_rport *tgt,
struct bnx2fc_els_cb_arg *cb_arg)
__must_hold(&tgt->tgt_lock)
{
struct bnx2fc_mp_req *mp_req;
struct fc_frame_header *fc_hdr, *fh;
@ -375,6 +376,7 @@ static void bnx2fc_srr_compl(struct bnx2fc_rport *tgt,
static void bnx2fc_rec_compl(struct bnx2fc_rport *tgt,
struct bnx2fc_els_cb_arg *cb_arg)
__must_hold(&tgt->tgt_lock)
{
struct bnx2fc_cmd *orig_io_req, *new_io_req;
struct bnx2fc_cmd *rec_req;

View File

@ -1286,6 +1286,7 @@ void bnx2fc_process_seq_cleanup_compl(struct bnx2fc_rport *tgt,
struct bnx2fc_cmd *seq_clnp_req,
struct fcoe_task_ctx_entry *task,
u8 rx_state)
__must_hold(&tgt->tgt_lock)
{
struct bnx2fc_els_cb_arg *cb_arg = seq_clnp_req->cb_arg;
struct bnx2fc_cmd *orig_io_req = cb_arg->aborted_io_req;