From 94602d84163c127ec2374fba0fcb6587a07785ce Mon Sep 17 00:00:00 2001 From: Richard Fitzgerald Date: Mon, 28 Apr 2025 10:08:03 +0100 Subject: [PATCH] ASoC: wm_adsp: Don't use no_free_ptr() when passing to PTR_ERR() It's no longer necessary to no_free_ptr() an auto-freed pointer before passing it to PTR_ERR(). This was fixed by commit cd7eb8f83fcf ("mm/slab: make __free(kfree) accept error pointers"). Removing the no_free_ptr() avoids the spurious warning "inconsistent IS_ERR and PTR_ERR". Fixes: b5d057a86e20 ("ASoC: wm_adsp: Use vmemdup_user() instead of open-coding") Signed-off-by: Richard Fitzgerald Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202504270751.nR3Ngfrq-lkp@intel.com/ Link: https://patch.msgid.link/20250428090803.97909-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown --- sound/soc/codecs/wm_adsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index a2e9f32209cf..e822979e6a19 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -419,7 +419,7 @@ static int wm_coeff_tlv_put(struct snd_kcontrol *kctl, void *scratch __free(kvfree) = vmemdup_user(bytes, size); if (IS_ERR(scratch)) - return PTR_ERR(no_free_ptr(scratch)); + return PTR_ERR(scratch); return cs_dsp_coeff_lock_and_write_ctrl(cs_ctl, 0, scratch, size); }