github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-30 01:53:29 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ACPI: TAD: Use dev_groups in struct device_driver

Browse Source 
Instead of creating and removing the device sysfs attributes directly
during probe and remove of the driver, respectively, use dev_groups in
struct device_driver to point to the attribute definitions and let the
core take care of creating and removing them.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2836803.mvXUDI8C0e@rafael.j.wysocki
This commit is contained in:
Rafael J. Wysocki 2026-03-10 21:29:29 +01:00
parent 6db176eb41
commit 93afe8ba9b
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/acpi/acpi_tad.c
View File

@ -586,6 +586,11 @@ static const struct attribute_group acpi_tad_attr_group = {
.is_visible = acpi_tad_attr_is_visible, .is_visible = acpi_tad_attr_is_visible,
}; };
static const struct attribute_group *acpi_tad_attr_groups[] = {
&acpi_tad_attr_group,
NULL,
};
#ifdef CONFIG_RTC_CLASS #ifdef CONFIG_RTC_CLASS
/* RTC class device interface */ /* RTC class device interface */
@ -663,8 +668,6 @@ static void acpi_tad_remove(struct platform_device *pdev)
device_init_wakeup(dev, false); device_init_wakeup(dev, false);
sysfs_remove_group(&dev->kobj, &acpi_tad_attr_group);
scoped_guard(pm_runtime_noresume, dev) { scoped_guard(pm_runtime_noresume, dev) {
if (dd->capabilities & ACPI_TAD_AC_WAKE) { if (dd->capabilities & ACPI_TAD_AC_WAKE) {
acpi_tad_disable_timer(dev, ACPI_TAD_AC_TIMER); acpi_tad_disable_timer(dev, ACPI_TAD_AC_TIMER);
@ -687,7 +690,6 @@ static int acpi_tad_probe(struct platform_device *pdev)
struct acpi_tad_driver_data *dd; struct acpi_tad_driver_data *dd;
acpi_status status; acpi_status status;
unsigned long long caps; unsigned long long caps;
int ret;
/* /*
* Initialization failure messages are mostly about firmware issues, so * Initialization failure messages are mostly about firmware issues, so
@ -731,12 +733,6 @@ static int acpi_tad_probe(struct platform_device *pdev)
pm_runtime_enable(dev); pm_runtime_enable(dev);
pm_runtime_suspend(dev); pm_runtime_suspend(dev);
ret = sysfs_create_group(&dev->kobj, &acpi_tad_attr_group);
if (ret) {
acpi_tad_remove(pdev);
return ret;
}
if (caps & ACPI_TAD_RT) if (caps & ACPI_TAD_RT)
acpi_tad_register_rtc(dev); acpi_tad_register_rtc(dev);
@ -752,6 +748,7 @@ static struct platform_driver acpi_tad_driver = {
.driver = { .driver = {
.name = "acpi-tad", .name = "acpi-tad",
.acpi_match_table = acpi_tad_ids, .acpi_match_table = acpi_tad_ids,
.dev_groups = acpi_tad_attr_groups,
}, },
.probe = acpi_tad_probe, .probe = acpi_tad_probe,
.remove = acpi_tad_remove, .remove = acpi_tad_remove,