github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-09 13:44:03 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

dm vdo indexer: prevent delta list overflow on load

Browse Source 
Check for corrupted delta lists sizes that overflow the
memory available for the delta_lists. An overflow can
cause the delta list data to be written outside the
reserved delta memory space.

Signed-off-by: Matthew Sakai <msakai@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
This commit is contained in:
Matthew Sakai 2026-08-11 15:02:33 -04:00 committed by Mikulas Patocka
parent fd73f4a665
commit 936293c9f3
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/md/dm-vdo/indexer/delta-index.c
View File

@ -800,7 +800,7 @@ static void compute_new_list_offsets(struct delta_zone *delta_zone, u32 growing_
(delta_zone->size * BITS_PER_BYTE - delta_lists[tail_guard_index].size);
}
static void rebalance_lists(struct delta_zone *delta_zone)
static int rebalance_lists(struct delta_zone *delta_zone)
{
struct delta_list *delta_lists;
u32 i;
@ -811,9 +811,17 @@ static void rebalance_lists(struct delta_zone *delta_zone)
for (i = 0; i <= delta_zone->list_count + 1; i++)
used_space += get_delta_list_byte_size(&delta_lists[i]);
if (delta_zone->size < used_space) {
return vdo_log_warning_strerror(UDS_CORRUPT_DATA,
"delta zone lists overflow zone size %zu",
delta_zone->size);
}
compute_new_list_offsets(delta_zone, 0, 0, used_space);
for (i = 1; i <= delta_zone->list_count + 1; i++)
delta_lists[i].start = delta_zone->new_offsets[i];
return UDS_SUCCESS;
}
/* Start restoring a delta index from multiple input streams. */
@ -941,8 +949,11 @@ int uds_start_restoring_delta_index(struct delta_index *delta_index,
}
/* Prepare each zone to start receiving the delta list data. */
for (z = 0; z < delta_index->zone_count; z++)
rebalance_lists(&delta_index->delta_zones[z]);
for (z = 0; z < delta_index->zone_count; z++) {
result = rebalance_lists(&delta_index->delta_zones[z]);
if (result != UDS_SUCCESS)
return result;
}
return UDS_SUCCESS;
}