From 9133e0e2f7148044f0507211fd93724381f5122e Mon Sep 17 00:00:00 2001 From: Jian Guo Date: Fri, 17 Jul 2026 19:06:06 +0800 Subject: [PATCH] selftests/cgroup: Remove redundant cg_enter_current() call in test_core MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test_cgcore_no_internal_process_constraint_on_threads test has two back-to-back cg_enter_current(root) calls in its cleanup path. A single cg_enter_current() call atomically migrates the entire thread group to the target cgroup even for multi-threaded processes, and this test creates no extra threads or child processes that would require a second migration attempt. The second call is a harmless no-op once the process is already in the root cgroup, but it is redundant and inconsistent with the cleanup logic used in all other cgroup core selftest cases. Remove the duplicate call to clean up the code. No functional change is intended. Signed-off-by: Jian Guo Acked-by: Michal Koutný Tested-by: Tao Cui Signed-off-by: Tejun Heo --- tools/testing/selftests/cgroup/test_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/cgroup/test_core.c b/tools/testing/selftests/cgroup/test_core.c index 88ca832d4fc1..8e3f9b391e44 100644 --- a/tools/testing/selftests/cgroup/test_core.c +++ b/tools/testing/selftests/cgroup/test_core.c @@ -426,7 +426,6 @@ static int test_cgcore_no_internal_process_constraint_on_threads(const char *roo ret = KSFT_PASS; cleanup: - cg_enter_current(root); cg_enter_current(root); if (child) cg_destroy(child);