github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-28 00:53:34 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/i915/overlay: Extract i915_overlay_setup()

Browse Source 
Pull the gem/gt related bits of the overlay setup into
a separate function (i915_overlay_setup()) that will eventually
move to the i915 side of the parent vs. display driver split.

For now we'll also have to pass in the overlay struct, but
that will disappear once the i915 vs. display split is completed.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260226100738.29997-10-ville.syrjala@linux.intel.com
This commit is contained in:
Ville Syrjälä 2026-02-26 12:07:28 +02:00
parent b0d7a69ca0
commit 8f7bf40ce2
1 changed files with 25 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
drivers/gpu/drm/i915/display/intel_overlay.c
View File

@ -1430,39 +1430,49 @@ static int get_registers(struct intel_overlay *overlay, bool use_phys)
return err;
}
void intel_overlay_setup(struct intel_display *display)
static int i915_overlay_setup(struct drm_device *drm,
struct intel_overlay *overlay,
bool needs_physical)
{
struct drm_i915_private *dev_priv = to_i915(display->drm);
struct intel_overlay *overlay;
struct drm_i915_private *dev_priv = to_i915(drm);
struct intel_engine_cs *engine;
int ret;
if (!HAS_OVERLAY(display))
return;
engine = to_gt(dev_priv)->engine[RCS0];
if (!engine || !engine->kernel_context)
return -ENOENT;
overlay->context = engine->kernel_context;
i915_active_init(&overlay->last_flip,
NULL, intel_overlay_last_flip_retire, 0);
return get_registers(overlay, needs_physical);
}
void intel_overlay_setup(struct intel_display *display)
{
struct intel_overlay *overlay;
int ret;
if (!HAS_OVERLAY(display))
return;
overlay = kzalloc_obj(*overlay);
if (!overlay)
return;
ret = i915_overlay_setup(display->drm, overlay,
OVERLAY_NEEDS_PHYSICAL(display));
if (ret)
goto out_free;
overlay->display = display;
overlay->context = engine->kernel_context;
overlay->color_key = 0x0101fe;
overlay->color_key_enabled = true;
overlay->brightness = -19;
overlay->contrast = 75;
overlay->saturation = 146;
i915_active_init(&overlay->last_flip,
NULL, intel_overlay_last_flip_retire, 0);
ret = get_registers(overlay, OVERLAY_NEEDS_PHYSICAL(display));
if (ret)
goto out_free;
memset_io(overlay->regs, 0, sizeof(struct overlay_registers));
update_polyphase_filter(overlay->regs);
update_reg_attrs(overlay, overlay->regs);