github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 17:47:41 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

mm/damon/core: add kdamond_call() debug_sanity check

Browse Source 
kdamond_call() is the place where DAMON API callers are allowed to access
the DAMON context's public internal state including the monitoring
results.  Hence it is important to ensure it is called with the expected
DAMON context state.  Do the check under DAMON_DEBUG_SANITY.

Link: https://lore.kernel.org/20260522154026.80546-9-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
SeongJae Park 2026-05-22 08:40:19 -07:00 committed by Andrew Morton
parent 50d2dec8af
commit 8f793f1ad5
1 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
mm/damon/core.c
View File

@ -3329,6 +3329,37 @@ static void kdamond_usleep(unsigned long usecs)
usleep_range_idle(usecs, usecs + 1);
}
#ifdef CONFIG_DAMON_DEBUG_SANITY
static void damon_verify_ctx(struct damon_ctx *c)
{
struct damon_target *t;
struct damon_region *r;
damon_for_each_target(t, c) {
struct damon_region *prev_r = NULL;
unsigned int nr_regions = 0;
damon_for_each_region(r, t) {
WARN_ONCE(r->ar.start >= r->ar.end,
"region start (%lu) >= end (%lu)\n",
r->ar.start, r->ar.end);
WARN_ONCE(prev_r && prev_r->ar.end > r->ar.start,
"region overlap (%lu > %lu)\n",
prev_r->ar.end, r->ar.start);
prev_r = r;
nr_regions++;
}
WARN_ONCE(damon_nr_regions(t) != nr_regions,
"nr_regions mismatch: %u != %u\n",
damon_nr_regions(t), nr_regions);
}
}
#else
static void damon_verify_ctx(struct damon_ctx *c)
{
}
#endif
/*
* kdamond_call() - handle damon_call_control objects.
* @ctx: The &struct damon_ctx of the kdamond.
@ -3344,6 +3375,8 @@ static void kdamond_call(struct damon_ctx *ctx, bool cancel)
struct damon_call_control *control, *next;
LIST_HEAD(controls);
damon_verify_ctx(ctx);
mutex_lock(&ctx->call_controls_lock);
list_splice_tail_init(&ctx->call_controls, &controls);
mutex_unlock(&ctx->call_controls_lock);