github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 22:14:04 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

of: property: decrement node refcount in of_fwnode_get_reference_args()

Browse Source 
[ Upstream commit 60d865bd5a ]

In of_fwnode_get_reference_args(), the refcount of of_args.np has
been incremented in the case of successful return from
of_parse_phandle_with_args() or of_parse_phandle_with_fixed_args().

Decrement the refcount if of_args is not returned to the caller of
of_fwnode_get_reference_args().

Fixes: 3e3119d308 ("device property: Introduce fwnode_property_get_reference_args")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Frank Rowand <frowand.list@gmail.com>
Link: https://lore.kernel.org/r/20221121023209.3909759-1-yangyingliang@huawei.com
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Yang Yingliang 2022-11-21 10:32:09 +08:00 committed by Greg Kroah-Hartman
parent be006212bd
commit 8f7047f418
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/of/property.c
View File

@ -956,8 +956,10 @@ of_fwnode_get_reference_args(const struct fwnode_handle *fwnode,
nargs, index, &of_args); nargs, index, &of_args);
if (ret < 0) if (ret < 0)
return ret; return ret;
if (!args) if (!args) {
of_node_put(of_args.np);
return 0; return 0;
}
args->nargs = of_args.args_count; args->nargs = of_args.args_count;
args->fwnode = of_fwnode_handle(of_args.np); args->fwnode = of_fwnode_handle(of_args.np);