mirror of
https://github.com/torvalds/linux.git
synced 2026-09-22 20:54:03 +02:00
f2fs: protect critical_task_priority updates with s_umount
The sysfs store path already takes s_umount for GC thread control
entries, and ckpt_thread_ioprio is covered as well.
critical_task_priority also updates checkpoint or GC kthread scheduling
state, but it is not covered by that serialization. It can race with
remount or teardown paths that are stopping those threads.
Protect critical_task_priority sysfs writes with s_umount too.
Fixes: 52190933c3 ("f2fs: sysfs: introduce critical_task_priority")
Cc: stable@kernel.org
Signed-off-by: Wenjie Qi <qiwenjie@xiaomi.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
parent
5cb33b00c8
commit
8e4692c6c1
|
|
@ -1007,7 +1007,8 @@ static ssize_t f2fs_sbi_store(struct f2fs_attr *a,
|
|||
ssize_t ret;
|
||||
bool gc_entry = (!strcmp(a->attr.name, "gc_urgent") ||
|
||||
a->struct_type == GC_THREAD);
|
||||
bool thread_entry = !strcmp(a->attr.name, "ckpt_thread_ioprio");
|
||||
bool thread_entry = !strcmp(a->attr.name, "ckpt_thread_ioprio") ||
|
||||
!strcmp(a->attr.name, "critical_task_priority");
|
||||
|
||||
if (gc_entry || thread_entry) {
|
||||
if (!down_read_trylock(&sbi->sb->s_umount))
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user