github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

misc: ad525x_dpot: drop redundant drvdata check

Browse Source 
ad525x_group is registered through the I2C and SPI drivers' dev_groups.
The driver core creates those groups only after probe succeeds and removes
them before invoking the driver's remove callback.  ad_dpot_probe() sets
the driver data before returning successfully, so ad525x_is_visible()
cannot legitimately observe a NULL value.

Drop the redundant check instead of silently hiding every attribute if
the driver lifecycle invariant is ever broken.

Signed-off-by: Jiale Yao <yaojiale02@163.com>
Link: https://patch.msgid.link/20260927123507.1219495-1-yaojiale02@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jiale Yao 2026-09-27 20:35:06 +08:00 committed by Greg Kroah-Hartman
parent f3ada175eb
commit 8c8dcfd43c
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/misc/ad525x_dpot.c
View File

@ -697,9 +697,6 @@ static umode_t ad525x_is_visible(struct kobject *kobj, struct attribute *attr,
struct dpot_data *data = dev_get_drvdata(dev);
int rdac;
if (!data)
return 0;
rdac = ad525x_attr_index(attr, dpot_attrib_wipers);
if (rdac >= 0)
return data->wipers & BIT(rdac) ? attr->mode : 0;