github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-23 22:14:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

mm/damon/sysfs: split probe setup function out

Browse Source 
damon_sysfs_set_probes() function is relatively long.  It has two nested
loop for setting two nested entities, namely probe and filter.  Split out
the probe level setup for readability.

Link: https://lore.kernel.org/20260630141726.92246-10-sj@kernel.org
Signed-off-by: SJ Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Hildenbrand <david@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
SJ Park 2026-06-30 07:17:23 -07:00 committed by Andrew Morton
parent 97ae89aa9f
commit 8c02207a06
1 changed files with 46 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

80
mm/damon/sysfs.c
View File

@ -1909,47 +1909,59 @@ static int damon_sysfs_set_attrs(struct damon_ctx *ctx,
return damon_set_attrs(ctx, &attrs);
}
static int damon_sysfs_set_probe(struct damon_probe *probe,
struct damon_sysfs_probe *sys_probe)
{
struct damon_sysfs_filters *sys_filters;
int i;
sys_filters = sys_probe->filters;
if (!sys_filters)
return 0;
for (i = 0; i < sys_filters->nr; i++) {
struct damon_sysfs_filter *sys_filter =
sys_filters->filters_arr[i];
struct damon_filter *filter;
filter = damon_new_filter(sys_filter->type,
sys_filter->matching,
sys_filter->allow);
if (!filter)
return -ENOMEM;
if (filter->type == DAMON_FILTER_TYPE_MEMCG) {
int err;
err = damon_sysfs_memcg_path_to_id(
sys_filter->path,
&filter->memcg_id);
if (err) {
damon_destroy_filter(filter);
return err;
}
}
damon_add_filter(probe, filter);
}
return 0;
}
static int damon_sysfs_set_probes(struct damon_ctx *ctx,
struct damon_sysfs_probes *sys_probes)
{
int i;
int i, err;
for (i = 0; i < sys_probes->nr; i++) {
struct damon_sysfs_filters *sys_filters =
sys_probes->probes_arr[i]->filters;
struct damon_probe *c;
int j;
struct damon_sysfs_probe *sys_probe;
struct damon_probe *p;
if (!sys_filters)
continue;
c = damon_new_probe();
if (!c)
p = damon_new_probe();
if (!p)
return -ENOMEM;
damon_add_probe(ctx, c);
for (j = 0; j < sys_filters->nr; j++) {
struct damon_sysfs_filter *sys_filter =
sys_filters->filters_arr[j];
struct damon_filter *filter;
filter = damon_new_filter(sys_filter->type,
sys_filter->matching,
sys_filter->allow);
if (!filter)
return -ENOMEM;
if (filter->type == DAMON_FILTER_TYPE_MEMCG) {
int err;
err = damon_sysfs_memcg_path_to_id(
sys_filter->path,
&filter->memcg_id);
if (err) {
damon_destroy_filter(filter);
return err;
}
}
damon_add_filter(c, filter);
}
damon_add_probe(ctx, p);
sys_probe = sys_probes->probes_arr[i];
err = damon_sysfs_set_probe(p, sys_probe);
if (err)
return err;
}
return 0;
}