github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-12 13:27:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

greybus: arche-platform: Export GPIOs after populating APBs

Browse Source 
Populating APBs operation can potentially fail and it would be better if
we export the GPIOs towards then end of the routine, so that we don't
need to unexport them on error cases.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2016-01-11 11:29:04 +05:30 committed by Greg Kroah-Hartman
parent 73658f2a28
commit 8adf71d1b4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/greybus/arche-platform.c
View File

@ -154,13 +154,13 @@ static int arche_platform_probe(struct platform_device *pdev)
arche_pdata->num_apbs = of_get_child_count(np);
dev_dbg(dev, "Number of APB's available - %d\n", arche_pdata->num_apbs);
export_gpios(arche_pdata);
/* probe all childs here */
ret = of_platform_populate(np, NULL, NULL, dev);
if (ret)
dev_err(dev, "no child node found\n");
export_gpios(arche_pdata);
dev_info(dev, "Device registered successfully\n");
return ret;
}