github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-29 17:43:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/etnaviv: fix error code in event_alloc()

Browse Source 
There are two "ret" variables declared in this function so setting
"ret = -EBUSY;" sets the wrong one.  The function ends up returning an
uninitialized variable.

Fixes: f098f9b804 ("drm/etnaviv: move runtime PM handling to events")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
This commit is contained in:
Dan Carpenter 2023-07-19 13:17:56 +03:00 committed by Lucas Stach
parent 9ec2afde83
commit 88c31d2dd1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/drm/etnaviv/etnaviv_gpu.c
View File

@ -1158,18 +1158,18 @@ static int event_alloc(struct etnaviv_gpu *gpu, unsigned nr_events,
int ret;
for (i = 0; i < nr_events; i++) {
unsigned long ret;
unsigned long remaining;
ret = wait_for_completion_timeout(&gpu->event_free, timeout);
remaining = wait_for_completion_timeout(&gpu->event_free, timeout);
if (!ret) {
if (!remaining) {
dev_err(gpu->dev, "wait_for_completion_timeout failed");
ret = -EBUSY;
goto out;
}
acquired++;
timeout = ret;
timeout = remaining;
}
spin_lock(&gpu->event_spinlock);