github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-22 12:44:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

regcache: Warn if regcache_sync() is called in cache_only mode

Browse Source 
Calling regcache_sync() while cache_only is enabled is invalid API
usage, since writes are intentionally kept in the cache and cannot
be synchronized to hardware.
Document that callers must disable cache_only before calling
regcache_sync(), and reject incorrect usage with a WARN_ON() and
-EINVAL.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Link: https://patch.msgid.link/20260720033238.52479-1-phucduc.bui@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
bui duc phuc 2026-07-20 10:32:37 +07:00 committed by Mark Brown
parent 1590cf0329
commit 86fc3483a4
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/base/regmap/regcache.c
View File

@ -397,6 +397,10 @@ static int rbtree_all(const void *key, const struct rb_node *node)
* volatile. In general drivers can choose not to use the provided
* syncing functionality if they so require.
*
* This pushes cached changes made while cache_only (e.g. suspend) down
* to hardware. The caller must disable cache_only before calling this
* function.
*
* Return a negative value on failure, 0 on success.
*/
int regcache_sync(struct regmap *map)
@ -413,6 +417,12 @@ int regcache_sync(struct regmap *map)
BUG_ON(!map->cache_ops);
map->lock(map->lock_arg);
if (WARN_ON(map->cache_only)) {
map->unlock(map->lock_arg);
return -EINVAL;
}
/* Remember the initial bypass state */
bypass = map->cache_bypass;
dev_dbg(map->dev, "Syncing %s cache\n",