github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-28 00:53:34 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

PCI: mediatek-gen3: Add error path for resume driver callbacks

Browse Source 
The resume callback currently does teardown in the conditional block
directly. This is going to get ugly when the pwrctrl calls are added.

Move the teardown to a proper error cleanup path.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://patch.msgid.link/20260324052002.4072430-5-wenst@chromium.org
This commit is contained in:
Chen-Yu Tsai 2026-03-24 13:19:56 +08:00 committed by Bjorn Helgaas
parent cf417e61fc
commit 867054421c
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/pci/controller/pcie-mediatek-gen3.c
View File

@ -1304,14 +1304,16 @@ static int mtk_pcie_resume_noirq(struct device *dev)
return err;
err = mtk_pcie_startup_port(pcie);
if (err) {
mtk_pcie_power_down(pcie);
return err;
}
if (err)
goto err_power_down;
mtk_pcie_irq_restore(pcie);
return 0;
err_power_down:
mtk_pcie_power_down(pcie);
return err;
}
static const struct dev_pm_ops mtk_pcie_pm_ops = {