github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-08 14:42:37 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: wireless: rockchip_wlan: fixes the warning with gcc-7.2 build

Browse Source 
when used the arm-linux-gnueabihf-gcc-7.2.1, had the below
warning information:

1) drivers/net/wireless/rockchip_wlan/rkwifi/bcmdhd/siutils.c:607:14:
    warning: self-comparison always evaluates to false
    [-Wtautological-compare]

2) drivers/net/wireless/rockchip_wlan/rkwifi/bcmdhd/dhd_common.c:3583:16:
    warning: comparison between pointer and zero character constant
    [-Wpointer-compare] error, forbidden warning: dhd_common.c:3583

Change-Id: Ida287252b7f20b17b68365b965edbff63ae7cbf9
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
This commit is contained in:
Caesar Wang 2017-12-13 17:21:41 +08:00 committed by Tao Huang
parent bdf6d5faff
commit 848ba9f9b3
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/rockchip_wlan/rkwifi/bcmdhd/dhd_common.c
View File

@ -3580,7 +3580,7 @@ dhd_pktfilter_offload_set(dhd_pub_t * dhd, char *arg)
htod16(WL_PKT_FILTER_MFLAG_NEG);
(argv[i])++;
}
if (argv[i] == '\0') {
if (strlen(argv[i]) == 0) {
printf("Pattern not provided\n");
goto fail;
}

3
drivers/net/wireless/rockchip_wlan/rkwifi/bcmdhd/siutils.c
View File

@ -604,11 +604,14 @@ si_doattach(si_info_t *sii, uint devid, osl_t *osh, volatile void *regs,
}
sih->bustype = bustype;
#ifdef BCMBUSTYPE
if (bustype != BUSTYPE(bustype)) {
SI_ERROR(("si_doattach: bus type %d does not match configured bus type %d\n",
bustype, BUSTYPE(bustype)));
return NULL;
}
#endif
/* bus/core/clk setup for register access */
if (!si_buscore_prep(sii, bustype, devid, sdh)) {