ASoC: SOF: trace: Use sof_ipc_get_ops() in sof_fw_trace_init

For the sake of safety use the sof_ipc_get_ops() to fetch the fw_tracing
ops to avoid cases when either sdev->ipc or sdev->ipc->ops might be NULL.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20221221102328.9635-11-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Peter Ujfalusi 2022-12-21 12:23:27 +02:00 committed by Mark Brown
parent 1cf79c3484
commit 8419fd90ee
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0

View File

@ -6,14 +6,16 @@
int sof_fw_trace_init(struct snd_sof_dev *sdev)
{
if (!sdev->ipc->ops->fw_tracing) {
const struct sof_ipc_fw_tracing_ops *fw_tracing = sof_ipc_get_ops(sdev, fw_tracing);
if (!fw_tracing) {
dev_info(sdev->dev, "Firmware tracing is not available\n");
sdev->fw_trace_is_supported = false;
return 0;
}
return sdev->ipc->ops->fw_tracing->init(sdev);
return fw_tracing->init(sdev);
}
void sof_fw_trace_free(struct snd_sof_dev *sdev)