github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 17:47:41 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: ibm: emac: mal: fix unchecked platform_get_irq return values

Browse Source 
platform_get_irq() returns a negative errno on failure.
Commit c4f5d0454c moved the platform_get_irq() calls and explicitly
removed the error checks that were previously present, claiming
devm_request_irq() can handle it. However, a negative IRQ number
passed to devm_request_irq() fails with -EINVAL instead of
propagating the real error from platform_get_irq().

Restore the missing error checks with proper errno propagation.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260603211734.30750-1-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Rosen Penev 2026-06-03 14:17:34 -07:00 committed by Jakub Kicinski
parent 6443f4f20b
commit 8084fc9292
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/ethernet/ibm/emac/mal.c
View File

@ -635,6 +635,11 @@ static int mal_probe(struct platform_device *ofdev)
mal->txeob_irq = platform_get_irq(ofdev, 0);
mal->rxeob_irq = platform_get_irq(ofdev, 1);
mal->serr_irq = platform_get_irq(ofdev, 2);
if (mal->txeob_irq < 0 || mal->rxeob_irq < 0 || mal->serr_irq < 0) {
err = mal->txeob_irq < 0 ? mal->txeob_irq :
mal->rxeob_irq < 0 ? mal->rxeob_irq : mal->serr_irq;
goto fail2;
}
if (mal_has_feature(mal, MAL_FTR_COMMON_ERR_INT)) {
mal->txde_irq = mal->rxde_irq = mal->serr_irq;
@ -643,6 +648,10 @@ static int mal_probe(struct platform_device *ofdev)
} else {
mal->txde_irq = platform_get_irq(ofdev, 3);
mal->rxde_irq = platform_get_irq(ofdev, 4);
if (mal->txde_irq < 0 || mal->rxde_irq < 0) {
err = mal->txde_irq < 0 ? mal->txde_irq : mal->rxde_irq;
goto fail2;
}
irqflags = 0;
hdlr_serr = mal_serr;
hdlr_txde = mal_txde;