github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-01 19:13:47 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ACPI: APEI: EINJ: prevent memory corruption in error_type_set()

Browse Source 
The "einj_buf" buffer is 32 chars.  If "count" is larger than that it
results in memory corruption.  Cap it at 31 so that we leave the last
character as a NUL terminator.  By the way, the highest reasonable value
for "count" is 24.

Fixes: 0c6176e1e1 ("ACPI: APEI: EINJ: Enable the discovery of EINJv2 capabilities")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/ae6286cf-4d73-4b97-8c0f-0782a65b8f51@sabinyo.mountain
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Dan Carpenter 2025-06-25 13:57:52 -05:00 committed by Rafael J. Wysocki
parent 8b148a9793
commit 80744a3bed
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/acpi/apei/einj-core.c
View File

@ -826,6 +826,10 @@ static ssize_t error_type_set(struct file *file, const char __user *buf,
int rc;
u64 val;
/* Leave the last character for the NUL terminator */
if (count > sizeof(einj_buf) - 1)
return -EINVAL;
memset(einj_buf, 0, sizeof(einj_buf));
if (copy_from_user(einj_buf, buf, count))
return -EFAULT;