github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

pinctrl: fix PINCTRL_SPPCTL=m

Browse Source 
The PINCTRL_SPPCTL option is defined as a tristate in Kconfig, and the
help text suggests that the user can build it as a module by setting to
'm'.

However, it cannot currently be set to 'm', because SOC_SP7021, the only
platform that supports it, is a bool option that uses 'select' on it.
Also, the SP7021 requires this driver to be built in, in order to boot.

Change the tristate to bool and fix the help text.

Tested on linux-next-2026-09-14 on a LTPP3G2 board.

This impossible tristate was detected by kconfirm, a static analysis tool
for Kconfig, by Julian Braha <julianbraha@gmail.com>.

Fixes: aa74c44be1 ("pinctrl: Add driver for Sunplus SP7021")
Signed-off-by: Andrew Gaylard <ag@ffroot.co.za>
Signed-off-by: Linus Walleij <linusw@kernel.org>
This commit is contained in:
Andrew Gaylard 2026-09-16 12:49:19 +02:00 committed by Linus Walleij
parent 9cbdce9383
commit 7dcf87d2db
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/pinctrl/sunplus/Kconfig
View File

@ -4,8 +4,8 @@
# #
config PINCTRL_SPPCTL config PINCTRL_SPPCTL
tristate "Sunplus SP7021 PinMux and GPIO driver" bool "Sunplus SP7021 PinMux and GPIO driver"
depends on SOC_SP7021 depends on SOC_SP7021 || COMPILE_TEST
depends on OF && HAS_IOMEM depends on OF && HAS_IOMEM
select GENERIC_PINCTRL_GROUPS select GENERIC_PINCTRL_GROUPS
select GENERIC_PINMUX_FUNCTIONS select GENERIC_PINMUX_FUNCTIONS
@ -16,6 +16,4 @@ config PINCTRL_SPPCTL
help help
Say Y here to support Sunplus SP7021 pinmux controller. Say Y here to support Sunplus SP7021 pinmux controller.
This driver requires the pinctrl framework. This driver requires the pinctrl framework.
GPIO is provided by the same driver. This driver also provides GPIO.
To compile this driver as a module, choose M here.
The module will be called sppinctrl.