scsi: fnic: Return appropriate error code for mem alloc failure

Return appropriate error code from fnic_probe when memory create slab pool
fails. Fix bug report.

Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: Arun Easi <aeasi@cisco.com>
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
Link: https://lore.kernel.org/r/20250110091746.17671-1-kartilak@cisco.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Karan Tilak Kumar 2025-01-10 01:17:46 -08:00 committed by Martin K. Petersen
parent 0620efe789
commit 7dbe3aa2f3

View File

@ -888,24 +888,32 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
pool = mempool_create_slab_pool(2, fnic_sgl_cache[FNIC_SGL_CACHE_DFLT]);
if (!pool)
if (!pool) {
err = -ENOMEM;
goto err_out_free_resources;
}
fnic->io_sgl_pool[FNIC_SGL_CACHE_DFLT] = pool;
pool = mempool_create_slab_pool(2, fnic_sgl_cache[FNIC_SGL_CACHE_MAX]);
if (!pool)
if (!pool) {
err = -ENOMEM;
goto err_out_free_dflt_pool;
}
fnic->io_sgl_pool[FNIC_SGL_CACHE_MAX] = pool;
pool = mempool_create_slab_pool(FDLS_MIN_FRAMES, fdls_frame_cache);
if (!pool)
if (!pool) {
err = -ENOMEM;
goto err_out_fdls_frame_pool;
}
fnic->frame_pool = pool;
pool = mempool_create_slab_pool(FDLS_MIN_FRAME_ELEM,
fdls_frame_elem_cache);
if (!pool)
if (!pool) {
err = -ENOMEM;
goto err_out_fdls_frame_elem_pool;
}
fnic->frame_elem_pool = pool;
/* setup vlan config, hw inserts vlan header */