From 7d91d0ae0cd94db834a6edafc1ab92e77f812154 Mon Sep 17 00:00:00 2001 From: Thorsten Blum Date: Tue, 29 Sep 2026 23:37:50 +0200 Subject: [PATCH] hwrng: atmel - use HZ_PER_MHZ in atmel_trng_init() Combine and inline the rate check to simplify the code. Drop the local rate variable and use HZ_PER_MHZ instead of the hard-coded frequency. Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu --- drivers/char/hw_random/atmel-rng.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c index 06e79d516743..fe444196e6b3 100644 --- a/drivers/char/hw_random/atmel-rng.c +++ b/drivers/char/hw_random/atmel-rng.c @@ -17,6 +17,7 @@ #include #include #include +#include #define TRNG_CR 0x00 #define TRNG_MR 0x04 @@ -85,20 +86,14 @@ static int atmel_trng_read(struct hwrng *rng, void *buf, size_t max, static int atmel_trng_init(struct atmel_trng *trng) { - unsigned long rate; int ret; ret = clk_prepare_enable(trng->clk); if (ret) return ret; - if (trng->has_half_rate) { - rate = clk_get_rate(trng->clk); - - /* if peripheral clk is above 100MHz, set HALFR */ - if (rate > 100000000) - writel(TRNG_HALFR, trng->base + TRNG_MR); - } + if (trng->has_half_rate && clk_get_rate(trng->clk) > 100 * HZ_PER_MHZ) + writel(TRNG_HALFR, trng->base + TRNG_MR); writel(TRNG_KEY | 1, trng->base + TRNG_CR);