github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-08 14:42:37 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

USB: gadget: f_adb: dequeue request on error in adb_read

Browse Source 
In adb_read(), if wait_event_interruptible() returns an error, we need to
remove the request from the EP queue.  Else, on the next call to adb_read(), we
will attempt to enqueue the request again, potentially corrupting the
queue.  This is what happens with musb_gadget_queue(), which does not check for
duplicate requests.

Signed-off-by: Iliyan Malchev <malchev@google.com>
This commit is contained in:
Iliyan Malchev 2011-02-18 11:28:32 -08:00 committed by Colin Cross
parent 090cbc41c9
commit 7d5250301d
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/usb/gadget/f_adb.c
View File

@ -321,6 +321,7 @@ static ssize_t adb_read(struct file *fp, char __user *buf,
if (ret < 0) {
dev->error = 1;
r = ret;
usb_ep_dequeue(dev->ep_out, req);
goto done;
}
if (!dev->error) {