From 7aa968415cd2fd7d5a345f5c6a9547c9d6b102b8 Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Wed, 22 Jul 2026 16:42:17 +0800 Subject: [PATCH] watchdog: sprd: Remove redundant dev_err() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang Link: https://lore.kernel.org/r/20260722084218.79073-10-panchuang@vivo.com Signed-off-by: Guenter Roeck --- drivers/watchdog/sprd_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/sprd_wdt.c b/drivers/watchdog/sprd_wdt.c index aacf04616fef..616b4d7f21d7 100644 --- a/drivers/watchdog/sprd_wdt.c +++ b/drivers/watchdog/sprd_wdt.c @@ -293,10 +293,8 @@ static int sprd_wdt_probe(struct platform_device *pdev) ret = devm_request_irq(dev, wdt->irq, sprd_wdt_isr, IRQF_NO_SUSPEND, "sprd-wdt", (void *)wdt); - if (ret) { - dev_err(dev, "failed to register irq\n"); + if (ret) return ret; - } wdt->wdd.info = &sprd_wdt_info; wdt->wdd.ops = &sprd_wdt_ops;