github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-31 11:37:06 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drivers: rpmh: Always bug_on() upon timeout in rpmh_write_batch()

Browse Source 
rpmh_rsc_debug() can race with tcs_tx_done() interrupt handler and
may not see any tcs busy and hence won't do bug_on(). Later it may
go ahead and free() the request which interrupt handler is processing.

Lets always bug_on() upon timeout.

Change-Id: I238a6a3639077850df158cb1f0190656e014bb57
Signed-off-by: Maulik Shah <quic_mkshah@quicinc.com>
This commit is contained in:
Maulik Shah 2021-07-04 12:51:45 +05:30 committed by Gerrit - the friendly Code Review server
parent 8d44aff55c
commit 7926741d4e
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/soc/qcom/rpmh.c
View File

@ -432,12 +432,10 @@ int rpmh_write_batch(const struct device *dev, enum rpmh_state state,
* we've returned from this function.
*/
rpmh_rsc_debug(ctrlr_to_drv(ctrlr), &compls[i]);
ret = -ETIMEDOUT;
goto exit;
BUG_ON(1);
}
}
exit:
kfree(ptr);
return ret;