github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 10:09:10 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ntfs: avoid self-deadlock during inode eviction

Browse Source 
An attribute-list update performed while allocating clusters can drop the
last reference to the temporary attribute inode. Evicting that inode
drops its reference to the base inode and can invoke ntfs_drop_big_inode()
for the base inode from within the base inode's own writeback path.

If the base inode is unlinked, ntfs_drop_big_inode() calls
truncate_setsize(), which waits for the inode's folio writeback to
complete. The same writeback worker is responsible for completing that
writeback, so it waits for itself indefinitely.

Prevent this self-deadlock by grabbing a reference to the base inode at the
beginning of ntfs_writepages() and releasing it at the end of the function.
This defers eviction until all bios have been submitted, allowing the wait
for folio writeback to complete safely.

Fixes: b041ca5625 ("ntfs: update iomap and address space operations")
Cc: stable@vger.kernel.org
Signed-off-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
This commit is contained in:
Hyunchul Lee 2026-07-02 14:28:16 +09:00 committed by Namjae Jeon
parent f72df3a4c3
commit 77dc384207
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
fs/ntfs/aops.c
View File

@ -251,6 +251,8 @@ static int ntfs_writepages(struct address_space *mapping,
.wbc = wbc,
.ops = &ntfs_writeback_ops,
};
bool need_iput = false;
int ret;
if (NVolShutdown(ni->vol))
return -EIO;
@ -267,7 +269,20 @@ static int ntfs_writepages(struct address_space *mapping,
return -EOPNOTSUPP;
}
return iomap_writepages(&wpc);
/*
* Prevent eviction in writeback to avoid deadlock in
* ntfs_drop_big_inode().
*/
if ((ni->type == AT_DATA || ni->type == AT_INDEX_ALLOCATION) &&
igrab(inode))
need_iput = true;
ret = iomap_writepages(&wpc);
if (need_iput)
iput(inode);
return ret;
}
static int ntfs_swap_activate(struct swap_info_struct *sis,