github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-27 08:33:17 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

xfs: avoid unnecessary open zone check in xfs_select_zone_nowait()

Browse Source 
When xfs_select_zone_nowait() is called with pack_tight equal to true,
the function xfs_select_open_zone_mru() is called if no open zone is
returned by xfs_select_open_zone_lru(), that is, when oz is NULL. The
open zone pointer return of xfs_select_zone_nowait() is then checked,
but this check is outside of the "if (pack_tight)" that trigered the
call to xfs_select_open_zone_mru(). In other word, this check is
unnecessarily done even when pack_tight is false.

Move the check for the return value of the call to
xfs_select_open_zone_mru() inside the if that controls the call to this
function, so that we do not uselessly test again the value of oz when
pack_tight is false.

No functional changes.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
This commit is contained in:
Damien Le Moal 2026-03-16 20:40:17 +09:00 committed by Carlos Maiolino
parent 01478f356f
commit 770323d418
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fs/xfs/xfs_zone_alloc.c
View File

@ -678,10 +678,11 @@ xfs_select_zone_nowait(
if (oz)
goto out_unlock;
if (pack_tight)
if (pack_tight) {
oz = xfs_select_open_zone_mru(zi, write_hint);
if (oz)
goto out_unlock;
if (oz)
goto out_unlock;
}
/*
* See if we can open a new zone and use that so that data for different