github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-26 01:52:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

Revert "selftests/filesystems: add mntns cleanup test"

Browse Source 
This reverts commit 3452eecbcc.

The test checks that the mounts of a destroyed mount namespace stay
connected. The commit that made them stay connected is reverted next
because it leaks superblocks and loop devices, so drop the test with it.

Link: https://patch.msgid.link/20260917-work-put_mnt_ns-revert-v1-1-34d9b8679e68@kernel.org
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
This commit is contained in:
Christian Brauner 2026-09-17 13:49:03 +02:00
parent f615c80a5d
commit 76ebb69da6
4 changed files with 0 additions and 67 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/testing/selftests/Makefile
View File

@ -49,7 +49,6 @@ TARGETS += filesystems/move_mount
TARGETS += filesystems/empty_mntns
TARGETS += filesystems/fsmount_ns
TARGETS += filesystems/fscontext_ns
TARGETS += filesystems/mntns_cleanup
TARGETS += filesystems/xattr
TARGETS += firmware
TARGETS += fpu

2
tools/testing/selftests/filesystems/mntns_cleanup/.gitignore vendored
View File

@ -1,2 +0,0 @@
# SPDX-License-Identifier: GPL-2.0-only
mntns_cleanup_test

6
tools/testing/selftests/filesystems/mntns_cleanup/Makefile
View File

@ -1,6 +0,0 @@
# SPDX-License-Identifier: GPL-2.0
TEST_GEN_PROGS := mntns_cleanup_test
CFLAGS += -Wall -O2 -g $(KHDR_INCLUDES)
include ../../lib.mk

58
tools/testing/selftests/filesystems/mntns_cleanup/mntns_cleanup_test.c
View File

@ -1,58 +0,0 @@
// SPDX-License-Identifier: GPL-2.0
#define _GNU_SOURCE
#include <errno.h>
#include <fcntl.h>
#include <sched.h>
#include <sys/mount.h>
#include <sys/stat.h>
#include <unistd.h>
#include "../../kselftest_harness.h"
FIXTURE(mntns_cleanup) {
};
FIXTURE_SETUP(mntns_cleanup)
{
if (geteuid() != 0)
SKIP(return, "test requires CAP_SYS_ADMIN");
ASSERT_EQ(unshare(CLONE_NEWNS), 0);
ASSERT_EQ(mount("", "/", NULL, MS_REC | MS_PRIVATE, NULL), 0);
rmdir("/mnt_dir");
ASSERT_EQ(mkdir("/mnt_dir", 0755), 0);
ASSERT_EQ(mount("tmpfs", "/mnt_dir", "tmpfs", 0, NULL), 0);
ASSERT_EQ(mkdir("/mnt_dir/hidden", 0755), 0);
ASSERT_EQ(mkdir("/mnt_dir/hidden/secret", 0755), 0);
ASSERT_EQ(mount("tmpfs", "/mnt_dir/hidden", "tmpfs", 0, NULL), 0);
}
FIXTURE_TEARDOWN(mntns_cleanup)
{
}
/* Mounts must stay connected when a mount namespace is cleaned up. */
TEST_F(mntns_cleanup, keeps_mounts_connected)
{
int fd, sfd, err;
fd = open("/mnt_dir", O_PATH | O_DIRECTORY | O_CLOEXEC);
ASSERT_GE(fd, 0);
/* Destroy the namespace; the fd keeps /mnt_dir alive. */
ASSERT_EQ(unshare(CLONE_NEWNS), 0);
sfd = openat(fd, "hidden/secret", O_RDONLY);
err = errno;
if (sfd >= 0)
close(sfd);
close(fd);
ASSERT_LT(sfd, 0)
TH_LOG("mount namespace teardown revealed what the overmount covered");
ASSERT_EQ(err, ENOENT);
}
TEST_HARNESS_MAIN